From d19ac3c7f75cb53693c0f3f9c06b1a00feb8d15e Mon Sep 17 00:00:00 2001 From: Chinmay Maheshwari Date: Mon, 15 Jan 2024 11:30:50 +0530 Subject: [PATCH 1/3] Temp changes to check semgrep failure --- packages/core/src/api.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/core/src/api.js b/packages/core/src/api.js index 28e982a54..127c5cfd9 100644 --- a/packages/core/src/api.js +++ b/packages/core/src/api.js @@ -97,8 +97,14 @@ export function createPercyServer(percy, port) { }) // post one or more comparisons, optionally waiting .route('post', '/percy/comparison', async (req, res) => { - let upload = percy.upload(req.body); - if (req.url.searchParams.has('await')) await upload; + if (percy.syncMode(req.body)) { + const snapshotPromise = new Promise((resolve, reject) => percy.upload(req.body, { resolve, reject })); + await snapshotPromise; + } else { + let upload = percy.upload(req.body); + if (req.url.searchParams.has('await')) await upload; + } + // generate and include one or more redirect links to comparisons let link = ({ name, tag }) => [ From 0381820d5b1a44c94f280d4a7b4af758c45b7ed4 Mon Sep 17 00:00:00 2001 From: Chinmay Maheshwari Date: Mon, 15 Jan 2024 11:33:17 +0530 Subject: [PATCH 2/3] temp change --- packages/core/src/api.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/src/api.js b/packages/core/src/api.js index 127c5cfd9..0a4f6c8c9 100644 --- a/packages/core/src/api.js +++ b/packages/core/src/api.js @@ -105,7 +105,6 @@ export function createPercyServer(percy, port) { if (req.url.searchParams.has('await')) await upload; } - // generate and include one or more redirect links to comparisons let link = ({ name, tag }) => [ percy.client.apiUrl, '/comparisons/redirect?', @@ -114,6 +113,7 @@ export function createPercyServer(percy, port) { }, { snake: true })) ].join(''); + console.log('temp change'); return res.json(200, Object.assign({ success: true }, req.body ? ( Array.isArray(req.body) ? { links: req.body.map(link) } : { link: link(req.body) } ) : {})); From ea02074e23400d3923a4e588bf87d034d5596d47 Mon Sep 17 00:00:00 2001 From: Chinmay Maheshwari Date: Mon, 15 Jan 2024 11:45:34 +0530 Subject: [PATCH 3/3] temp change semgrep --- packages/core/src/api.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/core/src/api.js b/packages/core/src/api.js index 0a4f6c8c9..c4af7ef16 100644 --- a/packages/core/src/api.js +++ b/packages/core/src/api.js @@ -113,8 +113,7 @@ export function createPercyServer(percy, port) { }, { snake: true })) ].join(''); - console.log('temp change'); - return res.json(200, Object.assign({ success: true }, req.body ? ( + return res.json(200, Object.assign({ success: false }, req.body ? ( Array.isArray(req.body) ? { links: req.body.map(link) } : { link: link(req.body) } ) : {})); })