From 853dd831f9c90552db7e3617f7f09c5cba22cb12 Mon Sep 17 00:00:00 2001 From: nilshah98 Date: Mon, 27 Nov 2023 16:00:03 +0530 Subject: [PATCH 1/3] feat: add captureServiceWorker flag when opening browser --- src/utils.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/utils.js b/src/utils.js index f7882904..7843d550 100644 --- a/src/utils.js +++ b/src/utils.js @@ -116,6 +116,7 @@ export async function* withPage(percy, url, callback, retry) { let page = yield percy.browser.page({ networkIdleTimeout: percy.config.discovery.networkIdleTimeout, requestHeaders: getAuthHeaders(percy.config.discovery), + captureServiceWorker: percy.config.captureServiceWorker, userAgent: percy.config.discovery.userAgent }); From 8488f81b6081a587a2eff9b0458e2fadfc386f33 Mon Sep 17 00:00:00 2001 From: nilshah98 Date: Tue, 28 Nov 2023 15:50:49 +0530 Subject: [PATCH 2/3] chore: rename captureServiceWorker -> captureMockedServiceWorker --- src/utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils.js b/src/utils.js index 7843d550..b9a3eb77 100644 --- a/src/utils.js +++ b/src/utils.js @@ -116,7 +116,7 @@ export async function* withPage(percy, url, callback, retry) { let page = yield percy.browser.page({ networkIdleTimeout: percy.config.discovery.networkIdleTimeout, requestHeaders: getAuthHeaders(percy.config.discovery), - captureServiceWorker: percy.config.captureServiceWorker, + captureMockedServiceWorker: percy.config.captureMockedServiceWorker, userAgent: percy.config.discovery.userAgent }); From 238679109880d00c5c7f5c049d8c8d777812ade3 Mon Sep 17 00:00:00 2001 From: nilshah98 Date: Wed, 29 Nov 2023 16:29:41 +0530 Subject: [PATCH 3/3] fix: captureMockedServiceWorker will be under discovery --- src/utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils.js b/src/utils.js index b9a3eb77..79b9486c 100644 --- a/src/utils.js +++ b/src/utils.js @@ -116,7 +116,7 @@ export async function* withPage(percy, url, callback, retry) { let page = yield percy.browser.page({ networkIdleTimeout: percy.config.discovery.networkIdleTimeout, requestHeaders: getAuthHeaders(percy.config.discovery), - captureMockedServiceWorker: percy.config.captureMockedServiceWorker, + captureMockedServiceWorker: percy.config.discovery.captureMockedServiceWorker, userAgent: percy.config.discovery.userAgent });