Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore_files used to filter out directories doesn't work #17

Open
botman99 opened this issue Mar 20, 2023 · 0 comments
Open

ignore_files used to filter out directories doesn't work #17

botman99 opened this issue Mar 20, 2023 · 0 comments

Comments

@botman99
Copy link

I want to transfer a stream from a remote Perforce server that I can't create virtual streams on (I don't have permissions to create one). I tried to use the 'ignore_files' list to filter out folders that I wanted to ignore, like so:

ignore_files:
- "/FolderOne/.*$"
- "/FolderTwo/.*$"
- "/FoderThree/Stuff/.*$

This fails with "Replication failure: missing elements in target changelist:" when validateSubmittedChange calls ChangelistComparer. The diff always contained files causing it to return false. The original code was this:

srcfiles = set([chRev.localFile for chRev in srclist if chRev.localFile not in filesToIgnore])
targfiles = set([chRev.localFile for chRev in targlist])

...but it seems like both the source and target lists of files should filter out the files being ignored. This seemed to work properly:

srcfiles = set([chRev.localFile for chRev in srclist if chRev.localFile not in filesToIgnore])
targfiles = set([chRev.localFile for chRev in targlist if chRev.localFile not in filesToIgnore])

...and the diff was empty with the 'ignore_files' being excluded and not submitted to the local Perforce server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant