Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the deprecated loadBalancerIP from the service definition #17

Open
indigo423 opened this issue Aug 8, 2024 · 3 comments
Open

Comments

@indigo423
Copy link
Contributor

Proposal

This field was under-specified, and its meaning varied across different implementations. It also did not support dual-stack networking, which led to its deprecation and potential removal in future API versions.
To address this deprecation in a Helm chart, you should consider the following steps:

  • Remove the loadBalancerIP field: If your Helm chart includes the loadBalancerIP field, remove it from the service definition. This field is no longer recommended for use.

  • Use Provider-Specific Annotations: Instead of using loadBalancerIP, you should use provider-specific annotations to specify the load balancer IP address. Different cloud providers may have their own annotations for setting the load balancer IP.

  • Consider Using loadBalancerClass: If applicable, you can specify a custom load balancer implementation using the .spec.loadBalancerClass field. This allows you to use a load balancer other than the default provided by the cloud provider.
    By following these steps, you can ensure your Helm chart is compatible with Kubernetes v1.24 and future versions.

@Nexucis
Copy link
Member

Nexucis commented Aug 9, 2024

Yes that's a good idea definitely. Would you like to help on this area @indigo423 ?

@indigo423
Copy link
Contributor Author

Yes that's a good idea definitely. Would you like to help on this area @indigo423 ?

Yes, I'm interested in helping to improve. I just saw it when I was working on the PR previously. I would say this is probably not something with a high priority. As I'm going now into the helm chart user role, using the Helm chart and getting my hands dirty on Perses itself, I can imagine we discover more important things to improve.

@Nexucis
Copy link
Member

Nexucis commented Aug 9, 2024

cool !

Would be great to support the whole configuration at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants