Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message when a special character is used for a cell-type/annotation #63

Open
Tobi1kenobi opened this issue Oct 12, 2020 · 0 comments
Open

Error message when a special character is used for a cell-type/annotation #63

Tobi1kenobi opened this issue Oct 12, 2020 · 0 comments
Labels
check&catch error checks and catching of errors. If very serious issue, report as bug enhancement New feature or request priority_high High priority

Comments

@Tobi1kenobi
Copy link
Contributor

Tobi1kenobi commented Oct 12, 2020 •
edited
Loading

Problem

Current error message is unclear and uninformative to users.

Solution

Simple enough, the implementation loops over all cell types and returns an error message when it encounters a name containing special characters. Instead return the cell-type/annotation responsible AND the error message.
@pascaltimshel pascaltimshel added check&catch error checks and catching of errors. If very serious issue, report as bug enhancement New feature or request priority_high High priority labels Jan 11, 2021
pascaltimshel pushed a commit that referenced this issue Jul 10, 2022
Fixed header of example file + improve check_safe_id message
c1e2a43 
- Remove dots ('.') in header of example/tabula_muris-test.csv to make compliant with updated regex
- Fixed and update common_func2.smk check_safe_id message (solve #63)
@pascaltimshel pascaltimshel mentioned this issue Jul 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
check&catch error checks and catching of errors. If very serious issue, report as bug enhancement New feature or request priority_high High priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pascaltimshel @Tobi1kenobi