Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate docs into single html #47

Open
soumak77 opened this issue Mar 27, 2018 · 1 comment
Open

consolidate docs into single html #47

soumak77 opened this issue Mar 27, 2018 · 1 comment

Comments

@soumak77
Copy link
Contributor

soumak77 commented Mar 27, 2018

Currently there are 4 html files in the docs:

  • index.html - displays D3 v3 examples from unpkg
  • index-d3v4.html - displays D3 v4 examples from unpkg
  • index-test.html - displays D3 v3 examples from locally built files
  • index-d3v4-test.html - displays D3 v4 examples from locally built files

The javascript files referenced by each html is the only difference between them. Instead of have 4 different files, create one single file and programmatically add the javascript references based on the query parameters. Create 2 query parameters:

If the user changes the D3 version, the page should be reloaded with the correct parameters so that the files are loaded properly. There is no need to allow the user to change from testing to non-testing. The npm start script should also be updated to add the query parameter test instead of loading index-test.html

@soumak77
Copy link
Contributor Author

soumak77 commented Mar 28, 2018

@germanattanasio I also added two extra profiles for testing (the ones with _2 appended to the names). If you click the Version 2 or Version 3 button for personality insights multiple times, it will randomly pick one of the 2 profiles to display.

This functionality can be changed to programmatically randomizing the profile each time the version buttons are clicked or add a separate randomize button. This way you can remove the 2 extra files.

@germanattanasio germanattanasio self-assigned this Mar 28, 2018
@germanattanasio germanattanasio removed their assignment Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants