You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
index-d3v4.html - displays D3 v4 examples from unpkg
index-test.html - displays D3 v3 examples from locally built files
index-d3v4-test.html - displays D3 v4 examples from locally built files
The javascript files referenced by each html is the only difference between them. Instead of have 4 different files, create one single file and programmatically add the javascript references based on the query parameters. Create 2 query parameters:
use value of parameter to load D3 files and set the D3 version for the sunburst chart options
If the user changes the D3 version, the page should be reloaded with the correct parameters so that the files are loaded properly. There is no need to allow the user to change from testing to non-testing. The npm start script should also be updated to add the query parameter test instead of loading index-test.html
The text was updated successfully, but these errors were encountered:
@germanattanasio I also added two extra profiles for testing (the ones with _2 appended to the names). If you click the Version 2 or Version 3 button for personality insights multiple times, it will randomly pick one of the 2 profiles to display.
This functionality can be changed to programmatically randomizing the profile each time the version buttons are clicked or add a separate randomize button. This way you can remove the 2 extra files.
Currently there are 4 html files in the docs:
index.html
- displays D3 v3 examples from unpkgindex-d3v4.html
- displays D3 v4 examples from unpkgindex-test.html
- displays D3 v3 examples from locally built filesindex-d3v4-test.html
- displays D3 v4 examples from locally built filesThe javascript files referenced by each html is the only difference between them. Instead of have 4 different files, create one single file and programmatically add the javascript references based on the query parameters. Create 2 query parameters:
./dist/index.js
v3
(default) orv4
If the user changes the D3 version, the page should be reloaded with the correct parameters so that the files are loaded properly. There is no need to allow the user to change from testing to non-testing. The
npm start
script should also be updated to add the query parametertest
instead of loadingindex-test.html
The text was updated successfully, but these errors were encountered: