Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start migrating to the new API process #258

Closed
ammar-faifi opened this issue Jun 24, 2022 · 3 comments · Fixed by #260
Closed

Start migrating to the new API process #258

ammar-faifi opened this issue Jun 24, 2022 · 3 comments · Fixed by #260
Assignees
Labels
enhancement New feature or request in progress We are working on the issue on one branch

Comments

@ammar-faifi
Copy link
Member

ammar-faifi commented Jun 24, 2022

As decided in petroly-initiative/petroly-django#60, we moved on from all graphene based libs to the strawberry based libs.

we see that in petroly-initiative/petroly-django#60 (comment) the API is ready to work on.

This transformation made some breaking changes in the API, we want to update files:

  • mutations.js
  • queries.js
@ammar-faifi ammar-faifi added the enhancement New feature or request label Jun 24, 2022
@ammar-faifi ammar-faifi self-assigned this Jun 24, 2022
@ammar-faifi ammar-faifi added the in progress We are working on the issue on one branch label Jun 24, 2022
@ammar-faifi
Copy link
Member Author

ammar-faifi commented Jun 24, 2022

btw All updates on the main branch is not advised at this stage, until the transformation succeeds

@Muhab2001 give me a sign to start working on from the last commit from main

@Muhab2001
Copy link
Collaborator

Yes the main branch is up-to-date, you can branch off it

@ammar-faifi ammar-faifi pinned this issue Jun 24, 2022
@ammar-faifi
Copy link
Member Author

the following mutation is deprecated

export const interactedCommunityMutation = gql`
  mutation InteractedCommunity($id: ID!) {
    hasInteractedCommunity(ID: $id) {
      liked
      reported
    }
  }
`;

replaced with the query

export const communityInteractionsQuery = gql`
  query CommunityInteractions($id: ID!) {
    communityInteractions(pk: $id) {
      liked
      reported
    }
  }
`;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress We are working on the issue on one branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants