Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "ping: support IPv4-Mapped-in-IPv6 target addresses"
This reverts commit 8ed7ffc. This is an incomplete implementation. While there are two attempts (PR#562 [1] PR#562 [2] and PR#563 [3]) to fix it, it's probably not a good idea to support IPv4-Mapped-in-IPv6 target addresses. There were concerns [4] about supporting this when discussion on BusyBox mailing list about patch bringing this functionality to BusyBox ping implementation: * ping is a low-level diagnostic tool, maybe it's not good to assume things like this, because IPv4-mapped IPv6 address format is not supported by raw sockets * it's not clear how -4 -6 switches should behave Although inetutils ping at least partly supports the feature [5]: - explicit ipv4 ping: % ping -c1 ::ffff:127.0.0.1 PING ::ffff:127.0.0.1 (127.0.0.1): 56 data bytes 64 bytes from 127.0.0.1: icmp_seq=0 ttl=64 time=0,100 ms - explicit ipv6 ping: % ping6 -c1 ::ffff:127.0.0.1 PING ::ffff:127.0.0.1 (::ffff:127.0.0.1): 56 data bytes ./ping/ping6: sending packet: Network is unreachable Because also fping did not want to support it [6], let's revert the feature. [1] iputils#561 [2] iputils#563 [3] iputils#562 [4] https://lists.busybox.net/pipermail/busybox/2024-October/090975.html [5] https://lists.busybox.net/pipermail/busybox/2024-October/090985.html [6] schweikert/fping#356 Signed-off-by: Petr Vorel <[email protected]>
- Loading branch information