Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash 5 compilation issue #356

Closed
Ergus opened this issue Jan 17, 2019 · 5 comments
Closed

Bash 5 compilation issue #356

Ergus opened this issue Jan 17, 2019 · 5 comments

Comments

@Ergus
Copy link

Ergus commented Jan 17, 2019

Hi bash5 is out in distributions like arch linux, but the regex to check the version in crosstool-NG/configure.ac does not include it. This fixes the issue:

diff --git a/configure.ac b/configure.ac
index 5d512fe8..872a73de 100644
--- a/configure.ac
+++ b/configure.ac
@@ -190,7 +190,7 @@ AC_CACHE_VAL([ac_cv_path__BASH],
 AC_CACHE_CHECK([for bash >= 3.1], [ac_cv_path__BASH],
     [AC_PATH_PROGS_FEATURE_CHECK([_BASH], [bash],
         [[_BASH_ver=$($ac_path__BASH --version 2>&1 \
-                     |$EGREP '^GNU bash, version (3\.[1-9]|4)')
+                     |$EGREP '^GNU bash, version (3\.[1-9]|4|5)')
           test -n "$_BASH_ver" && ac_cv_path__BASH=$ac_path__BASH ac_path__BASH_found=:]],                                                           
         [AC_MSG_RESULT([no])
          AC_MSG_ERROR([could not find bash >= 3.1])])])
@pfalcon
Copy link
Owner

pfalcon commented Jan 17, 2019

crosstool-NG/configure.ac is part of crosstool-NG project, not this project.

@nashley
Copy link

nashley commented Mar 18, 2019

Now that crosstool-NG has been updated, can the submodule commit referencing it be updated to pull in the change?

@rsnyman
Copy link

rsnyman commented Mar 22, 2019

Yes, please, I was trying to figure out why it wasn't building for me.

@milkpirate
Copy link

milkpirate commented Jan 3, 2022

Now that crosstool-NG has been updated, can the submodule commit referencing it be updated to pull in the change?

@pfalcon yes I agree with @nashley, could you please do so?

@igagis
Copy link

igagis commented Jan 3, 2022

@milkpirate see #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants