Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Error instead of UnschedulableAndUnresolvable in PreFilter #3

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Return Error instead of UnschedulableAndUnresolvable in PreFilter #3

merged 2 commits into from
Nov 9, 2023

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Nov 9, 2023

If PreFilter returns Unschedulable or UnschedulableAndUnresolvable, preemption will occur. Therefore, return Error and prevent preemption.

shioshiota
shioshiota approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@shioshiota shioshiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utam0k utam0k merged commit bbc4900 into master Nov 9, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shioshiota shioshiota shioshiota approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utam0k @shioshiota