Test pgautoupgrade container using AdventureWorks database #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinclift
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Awesome! This looks like a pretty solid foundation to build future things on. 😄
Really well done @andyundso. 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the Redash service in the testing process with the
AdventureWorksdatabase from here. Goal is that our upgrade script actually has some work to do compared to the previous iteration, helping us to spot errors.There is room to add some example queries in the process (e.g. do some
COUNTorSELECTagainst one or the other table) and check its result, but I think for now this change is good enough.