Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GUC_REPORT configurable a bit, at the very least for search_path #5

Open
JelteF opened this issue May 28, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@JelteF
Copy link
Member

JelteF commented May 28, 2024

With PgBouncer its track_extra_parameters setting you can make PgBouncer track other GUCs than the default few parameters (client_encoding, application_name, etc). But this only works for GUCs that have the GUC_REPORT flag set. Especially search_path is a GUC that people really want to track, but does not have GUC_REPORT set currently. We could easily set that from this extension, Citus actually does that. Getting support for this upstream would be best, but takes forever and doesn't work on old PG versions.

Relevant links:

  1. Trying to get search_path to be GUC_REPORT upstream: https://www.postgresql.org/message-id/flat/CAFh8B%3Dk8s7WrcqhafmYhdN1%2BE5LVzZi_QaYDq8bKvrGJTAhY2Q%40mail.gmail.com
  2. Docs for track_extra_parameters: https://www.pgbouncer.org/config.html#track_extra_parameters
  3. Making GUC_REPORT configurable for every GUC upstream: https://www.postgresql.org/message-id/flat/CAGECzQRbjxi72uY_b7MQaqG%3DYnDRvpo5imDniPtZsufj8WahTA%40mail.gmail.com#7d47fa745e32d83975b69136c50786bf
  4. Citus setting the GUC_REPORT flag for search_path: https://github.com/citusdata/citus/blob/fcc72d8a23da8e0f7ef91bf77077abba9796867d/src/backend/distributed/shared_library_init.c#L2711-L2720
@JelteF JelteF added the enhancement New feature or request label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant