Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py: Relax sentry-sdk constraint? #9

Open
tony opened this issue Nov 9, 2024 · 2 comments
Open

setup.py: Relax sentry-sdk constraint? #9

tony opened this issue Nov 9, 2024 · 2 comments

Comments

@tony
Copy link

tony commented Nov 9, 2024

  • graphene_django_sentry version: 0.4.0
  • Python version: 3.12
  • Operating System: Linux

Description

Installing via uv (repo, docs, PyPI) ran into the sentry-sdk constraint in setup.py:

'sentry-sdk==0.5.2',

  × No solution found when resolving dependencies:
  ╰─▶ Because graphene-sentry==0.4.0 depends on sentry-sdk>=0.5.2,<=0.10.1 and only graphene-sentry==0.4.0 is available, we can conclude that all versions of graphene-sentry depend on sentry-sdk>=0.5.2,<=0.10.1.
      And because your project depends on graphene-sentry and sentry-sdk>=2.14.0,<2.15, we can conclude that your project's requirements are unsatisfiable.

What I Did

uv 0.5.1 with these dependencies:

[project]
dependencies = [
   "python >=3.12,<4",
  "graphene-sentry >=0.4.0,<0.5",
  "sentry-sdk >=2.14.0,<2.15",
]
@tony
Copy link
Author

tony commented Nov 9, 2024

@phalt Forgive me! I got the wrong repository - I intended to write in graphene-sentry (PyPI)

However, it is a fork of your repo and has the same issue.

The solution would be to remove the sentry-sdk constraint from setup.py, so instead of:

requirements = [
    'graphene_django==2.2.0',
    'sentry-sdk==0.5.2',
]

Change it to:

requirements = [
    'graphene_django==2.2.0',
    'sentry-sdk',
]

Suggestions (from a downstream perspective):

  • Perhaps just have a minimum required version - if you're sure you need a certain API - while leaving the cap on new versions unbounded. This leaves the max downstream compatibility. Some package managers will lock users out of releases that'd otherwise work.
  • Consider doing this with both requirements (either removing the constraint or just imposing the minimum version).

@tony
Copy link
Author

tony commented Nov 9, 2024

Also, thank you for the project! 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant