Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLIR] Omit version comment by default #1313

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

rsetaluri
Copy link
Collaborator

This change avoids having to update the version comment in gold files for every CIRCT upgrade.

@rsetaluri rsetaluri requested a review from leonardt August 30, 2023 17:58
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4592ee0) 85.93% compared to head (1d747f5) 85.94%.

❗ Current head 1d747f5 differs from pull request most recent head 6319723. Consider uploading reports for the commit 6319723 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1313   +/-   ##
=======================================
  Coverage   85.93%   85.94%           
=======================================
  Files         169      169           
  Lines       17727    17727           
=======================================
+ Hits        15234    15235    +1     
+ Misses       2493     2492    -1     
Files Changed Coverage Δ
magma/backend/mlir/compile_to_mlir_opts.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rsetaluri rsetaluri merged commit 2a34fa6 into master Sep 21, 2023
4 checks passed
@rsetaluri rsetaluri deleted the mlir-omit-version-comment-by-default branch September 21, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants