Fix hashtag sending through 'undefined' if empty (#20)

* Fix hashtag sending through 'undefined' if empty * Bump package version to 0.0.5
phantomstudios · Nov 15, 2021 · 7afd4f9 · 7afd4f9
1 parent b8544d8
commit 7afd4f9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@phntms/react-share",
   "description": "An all-in-one React library to implement custom Sharing Meta and Social Media Sharing Buttons.",
-  "version": "0.0.4",
+  "version": "0.0.5",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
   "homepage": "https://github.com/phantomstudios/react-share#readme",

diff --git a/src/utils/getFacebookUrl.ts b/src/utils/getFacebookUrl.ts
@@ -9,11 +9,18 @@ export interface FacebookProps extends BaseShareProps {
   hashtag?: string;
 }
 
-export const getFacebookUrl = ({ url, quote, hashtag }: FacebookProps) =>
-  `https://www.facebook.com/sharer/sharer.php${objectToUrlParams({
+export const getFacebookUrl = ({
+  url,
+  quote,
+  hashtag: suppliedHashtag,
+}: FacebookProps) => {
+  let hashtag = suppliedHashtag;
+  if (hashtag && hashtag.charAt(0) !== "#") hashtag = `#${hashtag}`;
+  return `https://www.facebook.com/sharer/sharer.php${objectToUrlParams({
     u: url,
     quote,
-    hashtag: hashtag?.charAt(0) === "#" ? hashtag : `#${hashtag}`,
+    hashtag,
   })}`;
+};
 
 export default getFacebookUrl;