-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ERROR] No RateLimit present in response #228
Comments
No, probably not "too fast" but github's http response headers should contain a rate limit information that we parse to avoid just that. But for whatever reason, that header seems to be missing for your requests. I cannot reproduce this though:
Are you having any type of (transparent?) proxy in between which might filter our these headers? I guess we could change our download code to not barf on missing headers and just assume everything is fine, but it feels weird... |
May also have been a temporary issue on github's end ... |
I probably had exceeded the request limit or something before and got myself blocked. It worked fine again today. Do you have a check for that? |
Next time it happens I could try an make a wireshark capture if thats helpful. |
I read |
You certainly could exceed your limits. I ran into that while developing phive a lot before we implemented authentication token support. But: Github usually supplies a set of If you run into this problem again, you could try to do a curl/wget request to the URL shown before it happend in verbose mode so you get the HTTP response headers along. (If no URL is shown in the output, please make sure you get STDOUT as well as STDERR output ;) Phive supports using access tokens - simply set the |
Great thanks, for now I don't think this ticket needs action, if someone finds it through a search engine when having the same issue it could be re-opened. I will set a |
I just ran into this issue as well. export GITHUB_AUTH_TOKEN=gittoken fixed it. |
Looks like the code is having issues with either not seeing or not receiving the RateLimit headers from github. I'll reopen this and have a look. |
I am having the problem now.
|
I face the same issue when running phive on Codeship.com CI. On a local docker container it works though. |
Looks like Github changed the download of assets to be a redirect to s3 (of all places, why not azure? ;-p ) rather than having it count as an API hit. While that's a good thing, This needs a bit more investigation but i'll probably relax the code to simply be happy if no RateLimit header is there. |
The code already is relatively flexible in that regard. But: As it seems, Github no longer allows Using |
It would be awesome if someone could try this before I make a new release to see if that actually fixes this issue... :) |
On Debian the problem persists:
|
sigh I wish I could reproduce this ;)
The rate limit check works just fine? |
Looks like I managed:
I have no idea what's different on that box though ;) |
GithubAliasResolver.php:
HttpResponse.php:
CurlHttpClient.php
|
Found it! Technically, it's a bug on Github's side as their response headers are inconsistent. Some servers' response header use
|
Great news :). Mystery solved
|
@mjnbock I know where the exception came from but I wanted a scenario to reproduce the issue. But thanks :) |
Okay, fix implemented and tested. Will be in the next release. |
@theseer I just ran into this on a Windows 7 box. Is there an ETA for the next release? |
@ravage84 Working on it, with a bit of luck (read: my daughter sleeping a bit earlier today ;) ) I'll release 0.14.0 today. |
I also just ran into it today for "selfupdate". So the release is very welcome indeed :) |
To encourage fixing this, I am posting obligatory "me too" |
Me too on |
There is no backport for PHP7.1, right? We still build docker images for PHP7.1 and currently phive does not seem to work here anymore :( |
I created a 0.13.3 Release for you. This will mark the definite end for PHP 7.1 compatible releases though. |
wow, awesome, thanks :) |
I ran into this problem just now, and adding a |
@ramsey What version where you having this issue with? While you of course might have run into a Rate Limit issue in general, this particular bug should no longer exist. |
@theseer I was contributing to CaptainHook when I ran into this issue, so it's possible they're using an older version of Phive. Their CONTRIBUTING.md instructions show this command, which is where I saw the error:
|
Thanks! The command call looks sane, but indeed they are on 0.13.2. The problem is fixed in /ping @sebastianfeldmann |
Thanks for the ping, I updated |
I'm getting the error on version 0.13.3:
|
I don't see how this would be possible. And, worse, I cannot reproduce it. Is that the only output you get? |
Okay, managed. Interesting. |
Looks like I didn't backport all of the Fix in |
xD |
I downloaded latest 0.14.4 manually. When I look into It no longer complains about RateLimit. It does complain that I use PHP 7.1, but that's a different issue… |
I said 0.13.4 for PHP <7.2 ;-)
Am Montag, 21. September 2020 schrieb Dawid Nowak:
… I downloaded latest 0.14.4 manually. When I look into `phive.phar/.phar/stub.php` I can see that it is 0.14.4 –– OK.
It no longer complains about RateLimit.
It does complain that I use PHP 7.1, but that's a different issue…
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#228 (comment)
--
Gesendet von meinem Sailfish-Gerät.
|
Oh, my bad. It works! Thx :) |
Well, it worked for a few times…
|
I admit I'm confused. The exception is thrown when So that must be the culprit. But for that to fail, Github must not be responding with So I'm lost as to why this might be happening. |
Ah! Github started to block HEAD requests to their rate limit API endpoint. |
Okeeeeey… So i guess you know how to fix that?
Sure, bring it on :) |
Try |
It's happening again on
|
I get the following error when trying to build my docker file which worked fine a couple hours ago.
In a previous run it failed one package earlier:
The 6 packages I downloaded before this worked fine. What could be going on? Am I downloading too fast?
The text was updated successfully, but these errors were encountered: