Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: manual slope selection plot does not update if selected point is before current slope #121

Open
js3110 opened this issue Nov 15, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@js3110
Copy link
Collaborator

js3110 commented Nov 15, 2024

Description

When a manual slope selection is added, the plot only updates if the point selected is > time than the previous selection, otherwise it doesn't update visually. In the NCA results and in the table everything is fine, it is just the visuals of the plot.

To reproduce

Run NCA -> Slope selector -> select a point that is before the current slope (black) and then click the end point. The black point selected does not turn green.

Expected behaviour

The black point selected should turn green and be included in the line of best fit

@js3110 js3110 added the bug Something isn't working label Nov 15, 2024
@js3110 js3110 added this to aNCA Nov 15, 2024
@m-kolomanski m-kolomanski changed the title Bug: manual slope selection plot Bug: manual slope selection plot does not update if selected point is before current slope Nov 15, 2024
@Gero1999
Copy link
Collaborator

Gero1999 commented Dec 6, 2024

regarding this for whenever is taken care I would recommend to look first at how the index column (IX) is being created and how the lambda_plot is filtering them based on lambda.z.time.first! Changes in the app could have compromised the process and pass unnoticed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

3 participants