Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: More verbose/detailed error message when cut_date is fed into create_dcut incorrectly #181

Closed
manciniedoardo opened this issue Jul 13, 2023 · 1 comment · Fixed by #187 or #197
Assignees
Labels
enhancement New feature or request

Comments

@manciniedoardo
Copy link

Feature Idea

I recently ran the following code

dcut <- create_dcut(
  dataset_ds = source_data$ds ,
  ds_date_var = DSSTDTC,
  filter = DSDECOD == "RANDOMIZED",
  cut_date = cut_date,
  cut_description = "Clinical Cutoff Date"
)

where cut_date had been generated wrong upstream and so was NULL. Thus the function errored, but the message was:

Error: assert_that: length of assertion is not 1

when I would have like something along the lines of:

Error: `cut_date` is of class NULL instead of class Date

Relevant Input

No response

Relevant Output

No response

Reproducible Example/Pseudo Code

No response

@manciniedoardo manciniedoardo added the enhancement New feature or request label Jul 13, 2023
@alanaharris22
Copy link
Collaborator

This should get resolved with #187.
FYI @reesnj @barnett11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment