Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX : Browser strange toggle buttons #17827

Open
Nyan11 opened this issue Feb 14, 2025 · 10 comments
Open

UX : Browser strange toggle buttons #17827

Nyan11 opened this issue Feb 14, 2025 · 10 comments

Comments

@Nyan11
Copy link

Nyan11 commented Feb 14, 2025

Image

In the bottom right there are 5 buttons:

  • Make them all look the same
  • Make them more explicit
  • By default turn on the line count

From: #17812 (comment)

@jecisc

Issue 1:

  • I agree that they should look the same and all have a checkbox
  • I would vote yes to turn the line count on by default but we need to ask other opinions also

@Rinzwind

Regarding the line numbering default, note there’s a setting ‘Show lines numbers for all browsers’ (though I haven’t checked whether it still works, I don’t use it myself but a colleague did, we fixed a bug that it had in Pharo 12: pull request #13664).

@AlexisCnockaert
Copy link
Collaborator

The Show lines number count for all browsers option still works, so do we turn it by default or ask people before ?

@Nyan11
Copy link
Author

Nyan11 commented Feb 17, 2025

I think it is better to ask ask people about it.

I turn it on by default on all my images with a simple script in the pharo launcher:
ClyTextLineNumbersSwitchMorph showLineNumbers: true.

@AlexisCnockaert
Copy link
Collaborator

Okay thanks, and @Nyan11 does it make sense to you to put a check box even for the modify protocol icon? It opens a menu so it looks a little weird to me

@Nyan11
Copy link
Author

Nyan11 commented Feb 17, 2025

Image

The bottom buttons are separted in two categories:

  • protocol / extension editor.
  • browser / text editor options.

Issue 1 - Seperate the categories

First, we should add a separator between them, to show the distinction between the 2 categories of buttons.
We could also move one of the two categories somewhere else (put the browser / code options on the right with the character / line number display).

Issue 2 - Remove the cross button

There is a small button that remove the protocole or the package extension. I think it is useless because the same effect could be achieve by clicking either the protocol or extension label.

Issue 3 - Put the protocole label inside the protocole edit button.

Image

We can see on the hover that the button is separated from the label. It would be better if the label was inside the button.
It would be easier to understand that clicking on the label will edit the protocol.

Issue 4 - Have the same type of button for the browser / code options.

Currently, the Format has a small checkbox while the two others change their labels.
I think it would be better if the label stay the same and all options have their own checkbox.

Issue 5 - Have explicit names for the browser / code options.

Put explicit names like Format, Line Numbers and Word Wrap for the options.

@Nyan11
Copy link
Author

Nyan11 commented Feb 17, 2025

Okay thanks, and @Nyan11 does it make sense to you to put a check box even for the modify protocol icon? It opens a menu so it looks a little weird to me

For me it makes sense. The protocole is either a protocol or an extension. So it can be represented with a checkbox (binary choice).

@AlexisCnockaert
Copy link
Collaborator

For Issue 3, if we keep the current protocol and add the label 'Classify Method' before it would look strange, does having "Classify method, protocol/package is : currentProtocol" looks good to you?

@AlexisCnockaert
Copy link
Collaborator

something like this ?

Image

@Nyan11
Copy link
Author

Nyan11 commented Feb 17, 2025

I found it too verbose. but i am not sure how it can be reduce.

@Ducasse
Copy link
Member

Ducasse commented Feb 17, 2025

Alexis pay attention in english there is no space before :

BTW a shorter version can be Classified in protocol: building

@Rinzwind
Copy link
Contributor

@Nyan11, regarding your comment saying you “turn it on by default on all my images with a simple script in the pharo launcher”: you could also use ‘Save to Disk’ as shown on the following screenshot, the setting is then loaded in other images automatically (see #resumeSystemSettings for SystemSettingsPersistence).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants