fix: only fetch create and update events in secret history query (#106)

Co-authored-by: Nimish <[email protected]>
phasehq · Nov 12, 2023 · 150a68e · 150a68e
1 parent 00e58f3
commit 150a68e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/backend/backend/graphene/types.py b/backend/backend/graphene/types.py
@@ -176,7 +176,7 @@ class Meta:
         # interfaces = (relay.Node, )
 
     def resolve_history(self, info):
-        return SecretEvent.objects.filter(secret_id=self.id).order_by('timestamp')
+        return SecretEvent.objects.filter(secret_id=self.id, event_type__in=[SecretEvent.CREATE, SecretEvent.UPDATE]).order_by('timestamp')
 
 
 class KMSLogType(ObjectType):

diff --git a/frontend/components/environments/SecretRow.tsx b/frontend/components/environments/SecretRow.tsx
@@ -261,9 +261,7 @@ const HistoryDialog = (props: { secret: SecretType }) => {
     if (eventType === ApiSecretEventEventTypeChoices.D) return 'Deleted'
   }
 
-  const secretHistory = secret.history?.filter(
-    (event: Maybe<SecretEventType>) => event?.eventType! !== ApiSecretEventEventTypeChoices.R
-  )
+  const secretHistory = secret.history
 
   return (
     <>