feat: restrict service accounts from global access roles

phasehq · Nov 4, 2024 · 1c37150 · 1c37150
1 parent 445e19d
commit 1c37150
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/frontend/app/[team]/access/service-accounts/_components/CreateServiceAccountDialog.tsx b/frontend/app/[team]/access/service-accounts/_components/CreateServiceAccountDialog.tsx
@@ -49,7 +49,10 @@ export const CreateServiceAccountDialog = () => {
   const [thirdParty, setThirdParty] = useState(false)
   const [createPending, setCreatePending] = useState(false)
 
-  const roleOptions = roleData?.roles.filter((option: RoleType) => option.name !== 'Owner') || []
+  const roleOptions =
+    roleData?.roles.filter(
+      (option: RoleType) => option.name !== 'Owner' && option.name !== 'Admin'
+    ) || []
 
   useEffect(() => {
     if (roleData?.roles) {

diff --git a/frontend/app/[team]/access/service-accounts/_components/RoleSelector.tsx b/frontend/app/[team]/access/service-accounts/_components/RoleSelector.tsx
@@ -69,7 +69,10 @@ export const ServiceAccountRoleSelector = (props: { account: ServiceAccountType
     })
   }
 
-  const roleOptions = roleData?.roles.filter((option: RoleType) => option.name !== 'Owner') || []
+  const roleOptions =
+    roleData?.roles.filter(
+      (option: RoleType) => option.name !== 'Owner' && option.name !== 'Admin'
+    ) || []
 
   const disabled = isOwner || !userCanUpdateAccountRoles