Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve secret input masking #266

Open
rohan-chaturvedi opened this issue Jun 7, 2024 · 2 comments
Open

Improve secret input masking #266

rohan-chaturvedi opened this issue Jun 7, 2024 · 2 comments
Labels
enhancement New feature or request fosshack Issues for FOSS Hack 2024 frontend Change in frontend code

Comments

@rohan-chaturvedi
Copy link
Member

Is your feature request related to a problem?

Currently, input masking is handled by the browser by leveraging the html input type="password" attribute. Which this handles masking well, it introduces a few problems

  • The browser prompts the user to "Save this password" when editing secrets. (Browser specific workarounds to block this exist in some cases but are not ideal)
  • The masking looks different on different browsers
  • Masking very large, or multi line values is sub-optimal

Suggested approach

Use a password font such as this one to mask inputs.

Describe alternatives you've considered

Manually replacing masked characters with * or symbols. While this masks characters, it creates several other issues such as managing the value vs displayValue of inputs, removing the ability to manually copy values, etc

Additional context

Alternative approaches are welcome

@rohan-chaturvedi rohan-chaturvedi added enhancement New feature or request fosshack Issues for FOSS Hack 2024 frontend Change in frontend code labels Jun 7, 2024
@ayan-joshi
Copy link

I would like to work on this issue under FOSS HACK @rohan-chaturvedi

@nimish-ks
Copy link
Member

@ayan-joshi all yours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fosshack Issues for FOSS Hack 2024 frontend Change in frontend code
Projects
None yet
Development

No branches or pull requests

3 participants