Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dictionary view pane does not work on mobile #63

Open
oxdc opened this issue Feb 9, 2022 · 2 comments
Open

[Bug]: Dictionary view pane does not work on mobile #63

oxdc opened this issue Feb 9, 2022 · 2 comments

Comments

@oxdc
Copy link
Contributor

oxdc commented Feb 9, 2022

Describe the bug

The pane won't show anything except the input box, see the screenshot below,

image

If one emulates the mobile mode on a PC, contents and buttons are there but the page is misaligned,

image

Relevant errors (if available)

No response

Steps to reproduce

On a mobile:

  1. Open the command palette;
  2. Open the dictionary view;
  3. Type a word and hit Enter.

On a PC:

  1. Open the Obsidian Developer Console by pressing Ctrl + Shift + I;
  2. Execute app.emulateMobile(true) in the console;
  3. Open the command palette;
  4. Open the dictionary view;
  5. Type a word and hit Enter.

Expected Behavior

image

Addition context

No response

Language

No response

API Name

No response

Operating system

Android

@oxdc
Copy link
Contributor Author

oxdc commented Feb 10, 2022

I figured it out on my own, see #64.

Besides, for those who want a better layout on mobile, you may use the following css snippet,

div[data-type="dictionary-view"] .results .container {
  max-width: none !important;
}

div[data-type="dictionary-view"] h3 {
  font-size: 1.25rem;
  line-height: 1.2rem;
  margin: 0.3rem;
}

@phibr0
Copy link
Owner

phibr0 commented Feb 10, 2022

I will take a look at the styling for mobile when I have the time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: to do
Development

No branches or pull requests

2 participants