Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warns/fails with "will be initialized after [-Werror=reorder]" warning #37

Open
smuellener opened this issue Jun 16, 2021 · 0 comments

Comments

@smuellener
Copy link

There are multiple cases where members in the initializer list of classes have the wrong order. (see https://stackoverflow.com/questions/1564937/gcc-warning-will-be-initialized-after)

E.g.

PangolinMQTT\src\Packet.h:37:34: error: 'Packet::_controlcode' will be initialized after [-Werror=reorder]
PangolinMQTT\src\Packet.h:36:41: error: 'bool Packet::_hasId' [-Werror=reorder]
PangolinMQTT\src\Packet.h:51:9: error: when initialized here [-Werror=reorder]

Or also in AardvarkTCP\src\mbx.h

It would be great if you could ensure that the order is correct. I could also create pull requests for this if preferred..

Thank you, very excited to try this library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant