You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems like all modern browsers now support smooth scrolling as an argument to window.scrollBy. Can we rely on the browser's smooth scrolling implementation and remove the Vimium "use smooth scrolling" and "step size" options?
It seems reasonable to me that if the user has disabled smooth scrolling in the browser, then Vimium will inherit that preference and not have smooth scrolling. What do you think?
The first step is to POC this and see if the browser's implementation is equivalent to Vimium's current implementation.
The smooth scrolling is not as convenient as I once expected: if I hold on j to scroll longer, then a sequence of element.scrollBy({ y: 60, behavior: "smooth"}) will behave very weird, mainly because browser always interrupts an old scrolling and starts a new one.
I'm not familiar into the intricacies of how scrolling is implemented in Vimium, so I do apologize if my suggestion is strange. Would it be possible to try to change the custom scroll code to as easy as this and see how it behaves? I would love to do it myself, but looking at the existing code I feel completely lost. The code below is taken from a forked Vimari extension and it works really well.
It seems like all modern browsers now support smooth scrolling as an argument to window.scrollBy. Can we rely on the browser's smooth scrolling implementation and remove the Vimium "use smooth scrolling" and "step size" options?
It seems reasonable to me that if the user has disabled smooth scrolling in the browser, then Vimium will inherit that preference and not have smooth scrolling. What do you think?
The first step is to POC this and see if the browser's implementation is equivalent to Vimium's current implementation.
Related issues:
The text was updated successfully, but these errors were encountered: