Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should this be a plus sign? #33

Open
ruizengalways opened this issue Nov 25, 2019 · 4 comments
Open

Should this be a plus sign? #33

ruizengalways opened this issue Nov 25, 2019 · 4 comments

Comments

@ruizengalways
Copy link

tfoptflow/tfoptflow/core_warp.py

Line 194 in bdc7a72

query_points_on_grid = batched_grid - flow

@Superlee506
Copy link

@ruizengalways I also wonder about this

@JunggiLee12
Copy link

Is there any improvement of that~?

@shuaiyuan1996
Copy link

This has been discussed in this previous issue #6.

@yaanggny
Copy link

I believe a plus is required here. What we need is the remap image from image2. so we need + rather than a "-".

Besides, we can warp an image pair using the flow, the minus way generates bad result of alignment, but the plus one really align the images.
see this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ruizengalways @Superlee506 @shuaiyuan1996 @yaanggny @JunggiLee12