fix: tcp packet fragmentation (#700)

* fix: tcp packet fragmentation * solve sonar issue
philips-software · Aug 31, 2024 · c419e54 · c419e54
1 parent 99a068c
commit c419e54
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/services/network_instantiations/ConnectionBsd.cpp b/services/network_instantiations/ConnectionBsd.cpp
@@ -118,11 +118,12 @@ namespace services
 
     void ConnectionBsd::Send()
     {
-        int sent = 0;
+        long sent = 0;
 
         do
         {
-            sent = send(socket, reinterpret_cast<char*>(sendBuffer.contiguous_range(sendBuffer.begin()).begin()), sendBuffer.contiguous_range(sendBuffer.begin()).size(), 0);
+            std::vector<char> tmpBuffer(sendBuffer.begin(), sendBuffer.end());
+            sent = send(socket, tmpBuffer.data(), tmpBuffer.size(), 0);
 
             if (sent == -1)
             {

diff --git a/services/network_instantiations/ConnectionWin.cpp b/services/network_instantiations/ConnectionWin.cpp
@@ -120,7 +120,8 @@ namespace services
         do
         {
             UpdateEventFlags(); // If there is something to send, update the flags before calling send, because FD_SEND is an edge-triggered event.
-            sent = send(socket, reinterpret_cast<char*>(sendBuffer.contiguous_range(sendBuffer.begin()).begin()), sendBuffer.contiguous_range(sendBuffer.begin()).size(), 0);
+            std::vector<char> tmpBuffer(sendBuffer.begin(), sendBuffer.end());
+            sent = send(socket, tmpBuffer.data(), tmpBuffer.size(), 0);
 
             if (sent == SOCKET_ERROR)
             {