Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActorNetwork - sample_normal method log_probs issue #59

Open
zenineasa opened this issue Feb 24, 2023 · 0 comments
Open

ActorNetwork - sample_normal method log_probs issue #59

zenineasa opened this issue Feb 24, 2023 · 0 comments

Comments

@zenineasa
Copy link

zenineasa commented Feb 24, 2023

In the following line, the code can break if the value of 'self.max_action' is high enough that 'action' could have a high value, making the value within the logarithm negative. Negative values of logarithms return NaN.

log_probs -= T.log(1-action.pow(2)+self.reparam_noise)

log_probs -= T.log(1-action.pow(2)+self.reparam_noise)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant