Support new curly brace syntax #43
Conversation
|
Thanks for doing this! I'll have time tomorrow to test these changes locally. |
grammar.js
Outdated
| seq( | ||
| choice("{"), | ||
| prec.left( | ||
| seq( | ||
| choice( | ||
| $.partial_expression_value, | ||
| $.ending_expression_value, | ||
| $.expression_value | ||
| ), | ||
| choice("}") | ||
| ) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Partial/end expression is not allowed in {...}, it should always be a single expression. We can do this:
| seq( | |
| choice("{"), | |
| prec.left( | |
| seq( | |
| choice( | |
| $.partial_expression_value, | |
| $.ending_expression_value, | |
| $.expression_value | |
| ), | |
| choice("}") | |
| ) | |
| ) | |
| ) | |
| alias($.expression, "expression") |
Aliasing as string makes the node anonymous, so it appears as directive.
There was a problem hiding this comment.
Actually, I would consider parsing {...} as expression node, regardless if it's <div attr={...}> or <div>{...}</div>. So it would be this:
_node: ($) =>
- choice($.doctype, $.tag, $.component, $.text, $.comment, $.directive),
+ choice($.doctype, $.tag, $.component, $.text, $.comment, $.directive, $.expression),@connorlay wdyt?
There was a problem hiding this comment.
@jonatanklosko That makes sense to me!
parse curly braces directive only with single expressions Co-authored-by: Jonatan Kłosko <[email protected]>
|
Is tree-sitter able to respect |
kevinschweikert
force-pushed
the
feature/curly-braces
branch
from
25edee6 to
f8bb3dd
Compare
I think it may be possible, but I'm pretty sure it's not worth the complexity. The way I would try to implement it, would be to have a separate grammar node for |
Closes #42
This is me just jumping into the codebase but i wanted have a stab at it. Hope this helps and i'm happy to get feedback if anything needs changing!