Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

sync.cancel(); not working propperly on second cancel() #136

Open
dmaus opened this issue Jul 1, 2016 · 2 comments
Open

sync.cancel(); not working propperly on second cancel() #136

dmaus opened this issue Jul 1, 2016 · 2 comments
Assignees
Labels

Comments

@dmaus
Copy link

dmaus commented Jul 1, 2016

When canceling the sync process the first time, it works perfectly.
Starting the same process again and cancel again, contentsync still downloads the file.

It's easy to reproduce from the sample code. Just put sync.cancel() in the progress-callback and start it two times.

sync.on('progress', function(progress) {
  sync.cancel();
  console.log("Progress event", progress);
  app.setProgress(progress);
});

Only tested on iOS.

@imhotep imhotep self-assigned this Jul 2, 2016
@imhotep imhotep added the bug label Jul 2, 2016
@mansimarkaur
Copy link

I'd like to work on this as my first contribution. Can you please help me get started with it?

@imhotep
Copy link
Collaborator

imhotep commented Sep 27, 2016

@mansimarkaur For sure! Fork this repository, make your changes in separate branch and submit a pull request please.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

No branches or pull requests

3 participants