Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize each page's query so the GraphQL result is cached #416

Open
janosrusiczki opened this issue Mar 13, 2023 · 0 comments
Open

Optimize each page's query so the GraphQL result is cached #416

janosrusiczki opened this issue Mar 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@janosrusiczki
Copy link
Collaborator

janosrusiczki commented Mar 13, 2023

Spawned from #330

Ideally the SQL queries should be run once, but it needs to be investigated if it's worth implementing the whole caching mechanism.

I'm leaning towards NO because:

  1. When a visitor will load a page the SQL queries will be doubled but on subsequent navigation only GraphQL will be accessed;
  2. A search engine will only see the shadow page and GraphQL won't be accesed so SQL queries will only be run once - Apparently this is not true, at least Google understands the JS page;
  3. The current version of Apollo for Vue 3 didn't seem to support caching (at least not as easily as the previous version). Eventually I figured this one out.
@janosrusiczki janosrusiczki added the enhancement New feature or request label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant