Merge pull request #5 from php-etl/feature/actions

Using the RunnableInterface provided by php-etl/job-contracts

.github/workflows/quality.yaml

@@ -5,6 +5,9 @@ jobs:
         runs-on: ubuntu-latest
         steps:
             -   uses: actions/checkout@v3
+            -   uses: shivammathur/setup-php@v2
+                with:
+                  php-version: '8.2'
             -   name: Cs-Fixer
                 run: |
                     wget -q https://cs.symfony.com/download/php-cs-fixer-v3.phar -O php-cs-fixer

.github/workflows/rector.yaml

@@ -11,9 +11,6 @@ jobs:
       -
         if: github.event.pull_request.head.repo.full_name == github.repository
         uses: actions/checkout@v3
-        with:
-          # Must be used to trigger workflow after push
-          token: ${{ secrets.ACCESS_TOKEN }}
 
       -
         uses: shivammathur/setup-php@v2

.php-cs-fixer.dist.php

@@ -7,6 +7,7 @@
 return (new PhpCsFixer\Config())
     ->setRiskyAllowed(true)
     ->setRules([
+        '@PHP82Migration' => true,
         '@PHP81Migration' => true,
         '@PHP80Migration:risky' => true,
         '@PHPUnit84Migration:risky' => true,

composer.json

@@ -18,7 +18,8 @@
     "require": {
         "php": "^8.2",
         "psr/log": "^3.0",
-        "php-etl/action-contracts": "0.1.*"
+        "php-etl/action-contracts": "0.1.*",
+        "php-etl/satellite-contracts": "0.1.*"
     },
     "require-dev": {
         "rector/rector": "^0.15.0"

src/Action.php

@@ -6,15 +6,15 @@
 
 use Kiboko\Contract\Action\ActionInterface;
 use Kiboko\Contract\Action\ExecutingActionInterface;
-use Kiboko\Contract\Action\RunnableInterface;
 use Kiboko\Contract\Action\StateInterface;
+use Kiboko\Contract\Satellite\RunnableInterface;
 use Psr\Log\LoggerInterface;
 use Psr\Log\NullLogger;
 
-class Action implements ExecutingActionInterface, RunnableInterface
+readonly class Action implements ExecutingActionInterface, RunnableInterface
 {
     public function __construct(
-        private readonly LoggerInterface $logger = new NullLogger(),
+        private LoggerInterface $logger = new NullLogger(),
     ) {
     }
 
@@ -42,7 +42,7 @@ public function execute(ActionInterface $action, StateInterface $state): Executi
         return $this;
     }
 
-    public function run(): int
+    public function run(int $interval = 1000): int
     {
         return 1;
     }