Fixed PHPStan errors

php-etl · Oct 26, 2023 · 45dc906 · 45dc906
1 parent 3bad503
commit 45dc906
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/src/Cloud/DTO/JobList.php b/src/Cloud/DTO/JobList.php
@@ -8,6 +8,7 @@
 
 readonly class JobList implements \Countable, \IteratorAggregate
 {
+    /** @var DTO\Workflow\JobInterface<DTO\Workflow\Pipeline|DTO\Workflow\Action>[]  */
     private array $jobs;
 
     public function __construct(
@@ -27,11 +28,6 @@ public function getIterator(): \Traversable
     public function codes(): array
     {
         $jobs = $this->jobs;
-
-        /**
-         * @var DTO\Workflow\Pipeline|DTO\Workflow\Action $left
-         * @var DTO\Workflow\Pipeline|DTO\Workflow\Action $right
-         */
         usort($jobs, fn (DTO\Workflow\JobInterface $left, DTO\Workflow\JobInterface $right) => $left->order <=> $right->order);
 
         return array_map(fn (DTO\Workflow\JobInterface $job) => $job->code->asString(), $jobs);

diff --git a/src/Cloud/Workflow.php b/src/Cloud/Workflow.php
@@ -183,11 +183,8 @@ private static function fromApiModel(Api\Client $client, Api\Model\WorkflowRead
                                     $step->getLabel(),
                                     new StepCode($step->getCode()),
                                     $step->getConfiguration(),
-                                    new ProbeList(...array_map(
-                                        fn (Api\Model\Probe $probe, int $order) => new Probe($probe->getLabel(), $probe->getCode(), $order),
-                                        $probes = $step->getProbes(),
-                                        range(0, is_countable($probes) ? \count($probes) : 0),
-                                    )),
+                                    /** TODO : implement probes when it is enabled */
+                                    new ProbeList(),
                                     $order
                                 ),
                                 $steps = $job->getPipeline()->getSteps(),