Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated php-etl contract versions #11

Merged
merged 14 commits into from
Jan 11, 2024
Merged

Updated php-etl contract versions #11

merged 14 commits into from
Jan 11, 2024

Conversation

sebprt
Copy link
Collaborator

@sebprt sebprt commented Nov 20, 2023

No description provided.

@sebprt sebprt requested a review from gplanchat November 20, 2023 14:07
@sebprt sebprt self-assigned this Nov 20, 2023
@sebprt sebprt added the GTM Good to merge label Nov 20, 2023
JoMessina
JoMessina reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@JoMessina JoMessina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phpstan 4 est cassé ici, c'est prévu d'être corrigé via d'autres packages ?

@sebprt sebprt added WIP Work in Progress and removed GTM Good to merge labels Nov 22, 2023
JoMessina
JoMessina reviewed Nov 23, 2023
View reviewed changes
Copy link
Contributor

@JoMessina JoMessina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remarque concernant les workflow github. Sur l'action phpstan 5 dans quality tu set un php_version qui n'est pas fait ailleurs. Est-ce obligatoire ou pas ? Il faut peut-être normaliser ici.

gplanchat
gplanchat requested changes Nov 24, 2023
View reviewed changes
src/Client/Client.php Outdated Show resolved Hide resolved
src/ContactLoader.php Outdated Show resolved Hide resolved
src/ContactLoader.php Outdated Show resolved Hide resolved
src/ContactLoader.php Outdated Show resolved Hide resolved
src/ContactLookup.php Outdated Show resolved Hide resolved
@sebprt sebprt requested a review from gplanchat November 30, 2023 08:19
@sebprt sebprt added GTM Good to merge and removed WIP Work in Progress labels Nov 30, 2023
gplanchat
gplanchat requested changes Dec 19, 2023
View reviewed changes
src/Client/Client.php Outdated Show resolved Hide resolved
src/Client/Client.php Outdated Show resolved Hide resolved
src/Client/Client.php Outdated Show resolved Hide resolved
@sebprt sebprt requested a review from gplanchat December 20, 2023 16:28
@sebprt sebprt force-pushed the feature/update-contracts branch from f39af57 to 4bc180a Compare January 10, 2024 13:45
@gplanchat gplanchat merged commit b4c354d into main Jan 11, 2024
4 of 8 checks passed
@gplanchat gplanchat deleted the feature/update-contracts branch January 11, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoMessina JoMessina JoMessina approved these changes

@gplanchat gplanchat gplanchat approved these changes

Assignees

@sebprt sebprt

Labels
GTM Good to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebprt @gplanchat @JoMessina @actions-user