Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only required params in RouteData #43

Closed
SOHELAHMED7 opened this issue Sep 5, 2024 · 0 comments · Fixed by #44
Closed

Use only required params in RouteData #43

SOHELAHMED7 opened this issue Sep 5, 2024 · 0 comments · Fixed by #44
Assignees

Comments

@SOHELAHMED7
Copy link
Member

Resolve below TODO:

File: src/lib/items/RouteData.php::init()

L192

               $this->params[$paramName] = [
                    //@TODO: use only required params
                    //'required'=> $pathParameters[$paramName]->required,
                    'type' => $pathParameters[$paramName]->schema->type ?? null,
                    //'model' => $additional ? SchemaResponseResolver::guessModelByRef($additional) : null,
                ];

Part of #10

and

Part of cebe#180

@SOHELAHMED7 SOHELAHMED7 self-assigned this Sep 5, 2024
@SOHELAHMED7 SOHELAHMED7 linked a pull request Sep 6, 2024 that will close this issue
cebe added a commit that referenced this issue Nov 12, 2024
…n-routedata

Resolve: Use only required params in RouteData #43
@cebe cebe closed this as completed in #44 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant