Skip to content

Commit 0e7bfd6

Browse files
committed
issue #1 add time to SAP_DATE and SAP_WEEK parsing
1 parent 7bef7c2 commit 0e7bfd6

File tree

1 file changed

+18
-16
lines changed

1 file changed

+18
-16
lines changed

tests/SapDateTimeTest.php

+18-16
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,13 @@ class SapDateTimeTest extends \PHPUnit_Framework_TestCase
3232
public static function validSapWeeks()
3333
{
3434
return [
35-
['201846', '2018 week 46'],
36-
['190801', '1908 week 01'],
37-
['190853', '1908 week 53'],
38-
['190952', '1909 week 52'],
39-
['191052', '1910 week 52'],
40-
['191152', '1911 week 52'],
41-
['191301', '1913 week 01']
35+
['201846', '2018 week 46', '2018-11-12 00:00:00'],
36+
['190801', '1908 week 01', '1907-12-30 00:00:00'],
37+
['190853', '1908 week 53', '1908-12-28 00:00:00'],
38+
['190952', '1909 week 52', '1909-12-27 00:00:00'],
39+
['191052', '1910 week 52', '1910-12-26 00:00:00'],
40+
['191152', '1911 week 52', '1911-12-25 00:00:00'],
41+
['191301', '1913 week 01', '1912-12-30 00:00:00']
4242
];
4343
}
4444

@@ -47,14 +47,16 @@ public static function validSapWeeks()
4747
*
4848
* @param string $sapWeek The SAP week string.
4949
* @param string $expected The expected week in format <year>W<week>.
50+
* @param string $timestamp The expected timestamp in format Y-m-d H:i:s
5051
* @dataProvider validSapWeeks
5152
* @throws \Exception
5253
*/
53-
public function testParseSapWeeks($sapWeek, $expected)
54+
public function testParseSapWeeks($sapWeek, $expected, $timestamp)
5455
{
5556
$dateTime = SapDateTime::createFromFormat(SapDateTime::SAP_WEEK, $sapWeek);
5657
static::assertInstanceOf(\DateTime::class, $dateTime);
5758
static::assertSame($expected, $dateTime->format('o \w\e\ek W'));
59+
static::assertSame($timestamp, $dateTime->format('Y-m-d H:i:s'));
5860
}
5961

6062
/**
@@ -123,13 +125,13 @@ public function testCreateSapWeeks($timestamp, $expected)
123125
public static function sapDatesAndIsoDates()
124126
{
125127
return [
126-
['20181101', '2018-11-01'],
127-
['19071231', '1907-12-31'],
128-
['19080101', '1908-01-01'],
129-
['19091201', '1909-12-01'],
130-
['19100110', '1910-01-10'],
131-
['19110601', '1911-06-01'],
132-
['19120229', '1912-02-29']
128+
['20181101', '2018-11-01 00:00:00'],
129+
['19071231', '1907-12-31 00:00:00'],
130+
['19080101', '1908-01-01 00:00:00'],
131+
['19091201', '1909-12-01 00:00:00'],
132+
['19100110', '1910-01-10 00:00:00'],
133+
['19110601', '1911-06-01 00:00:00'],
134+
['19120229', '1912-02-29 00:00:00']
133135
];
134136
}
135137

@@ -143,7 +145,7 @@ public static function sapDatesAndIsoDates()
143145
public function testParseSapDates($sapDate, $isoDate)
144146
{
145147
$dateTime = SapDateTime::createFromFormat(SapDateTime::SAP_DATE, $sapDate);
146-
static::assertSame($isoDate, $dateTime->format('Y-m-d'));
148+
static::assertSame($isoDate, $dateTime->format('Y-m-d H:i:s'));
147149
}
148150

149151
/**

0 commit comments

Comments
 (0)