issue #1 set time only in case result is not false

gregor-j · gregor-j · commit 89d4a13d3a22 · 2020-02-28T15:59:01.000+01:00
diff --git a/src/SapDateTime.php b/src/SapDateTime.php
@@ -88,8 +88,11 @@ public static function createFromFormat(
             return static::createFromSapWeek($time, $timezone);
         }
         if ($format === static::SAP_DATE) {
-            return parent::createFromFormat($format, $time, $timezone)
-                ->setTime(0, 0, 0);
+            $result = parent::createFromFormat($format, $time, $timezone);
+            if ($result !== false) {
+                $result->setTime(0, 0, 0);
+            }
+            return $result;
         }
         return parent::createFromFormat($format, $time, $timezone);
     }

Original file line number	Diff line number	Diff line change
`@@ -88,8 +88,11 @@ public static function createFromFormat(`
`88`	`88`	`return static::createFromSapWeek($time, $timezone);`
`89`	`89`	`}`
`90`	`90`	`if ($format === static::SAP_DATE) {`
`91`		`- return parent::createFromFormat($format, $time, $timezone)`
`92`		`- ->setTime(0, 0, 0);`
	`91`	`+ $result = parent::createFromFormat($format, $time, $timezone);`
	`92`	`+ if ($result !== false) {`
	`93`	`+ $result->setTime(0, 0, 0);`
	`94`	`+ }`
	`95`	`+ return $result;`
`93`	`96`	`}`
`94`	`97`	`return parent::createFromFormat($format, $time, $timezone);`
`95`	`98`	`}`