Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag a new version #7

Open
tristanbes opened this issue Feb 27, 2019 · 3 comments
Open

Tag a new version #7

tristanbes opened this issue Feb 27, 2019 · 3 comments

Comments

@tristanbes
Copy link

Or we can't use it with Symfony4 without a new tag :-)

Thanks :-)

@emri99
Copy link
Contributor

emri99 commented Apr 30, 2019

@Nyholm I can help to fix travis build, just point me the direction.

For what I experiment on recent travis usage with recommended .travis.yml from Best Practices for Reusable Bundles, I can imagine several solutions:

  • revert .travis.yml to a simpler version
  • specify more precisely the dependencies to use (this commit on project has reduce CI length from 26min to 5min9s)

Both solutions have drawbacks, but I don't know better ones.

I achieve similar goal by:

  • using travis_retryand/or travis_wait here
  • expanding memory limit here

It's not a perfect but it works.

Do you have a better solution ? Please let me know :)

Related issue: composer/composer#7240

@Nyholm
Copy link
Member

Nyholm commented May 16, 2019

Thank you.

Yes, lets fix the build and tag a new version. Im all for updating the dependencies to be more specific.
If you also think travis.yml can be simpler please feel free to update.

Btw, I wrote that section of best practices =) But I think it was after I created this library.

@emri99
Copy link
Contributor

emri99 commented May 23, 2019

Hey !

On my way to fix builds, I don't know how to handle deprecation warning:

Remaining deprecation notices (5)
  5x: Creating a backup while dumping a message catalogue is deprecated since Symfony 3.1 and will be removed in 4.0. Use TranslationWriter::disableBackup() to disable the backup.
    4x in ConverterTest::testConvertJMS from Translation\Converter\Tests\Functional\Service
    1x in ConverterTest::testConvertYaml from Translation\Converter\Tests\Functional\Service
Script vendor/bin/simple-phpunit handling the test event returned with error code 1
The command "$TEST_COMMAND" exited with 1.

from: https://travis-ci.org/emri99/converter/jobs/536334862#L631

Adding SYMFONY_DEPRECATIONS_HELPER="weak" fix travis build #7.3 compared to builds #\6, but seems like a bad idea to hide those warnings every where as this is the reason of remaining jobs failures.

Should I hide those warnings ? only for some versions ? Should I modify source code to remove deprecated code in Converter ?

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants