Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group violations per rule in output #282

Open
annervisser opened this issue Aug 16, 2022 · 3 comments
Open

Group violations per rule in output #282

annervisser opened this issue Aug 16, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@annervisser
Copy link
Contributor

Feature Request

Q A
New Feature yes
RFC yes
BC Break no

Summary

Currently the output of violations is grouped by class (fqcn), and all violations are listed under that. If violations were additionally grouped per rule, this could add to the clarity of the output AND reduce the line-length by splitting into more lines.

The output would look something like this:

App\Domain\Model has 2 violations:
  violated rule: should not depend on classes outside namespace App\Domain because we want protect our domain
    - App\Domain\Model depends on App\Services\UserService (on line 14)
    - App\Domain\Model depends on App\Services\OtherService (on line 26)
  violated rule: should implement EntityInterface

This idea came up in discussion in this PR: #281 (comment)

I'd be able to pick this up and create a pull request when I have some spare time if this is a wanted feature

@AlessandroMinoccheri
Copy link
Member

Thanks @annervisser, let me know if you need some help!

@AlessandroMinoccheri AlessandroMinoccheri added the enhancement New feature or request label Aug 16, 2022
@dbu
Copy link
Contributor

dbu commented Feb 14, 2023

is this the same request as #187 ?

@AlessandroMinoccheri
Copy link
Member

Yes @dbu it seems the same request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants