Skip to content

Commit dead307

Browse files
committed
Fix tests
1 parent 10b7940 commit dead307

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

tests/controller/admin_controller_test.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -83,15 +83,15 @@ protected function setUp(): void
8383
parent::setUp();
8484

8585
global $phpbb_root_path, $phpEx;
86-
global $phpbb_dispatcher, $cache, $db, $user;
86+
global $phpbb_dispatcher, $cache, $db, $user, $language;
8787

8888
$lang_loader = new \phpbb\language\language_file_loader($phpbb_root_path, $phpEx);
8989

9090
// Load/Mock classes required by the controller class
9191
$this->template = $this->getMockBuilder('\phpbb\template\template')
9292
->disableOriginalConstructor()
9393
->getMock();
94-
$this->language = new \phpbb\language\language($lang_loader);
94+
$language = $this->language = new \phpbb\language\language($lang_loader);
9595
$user = new \phpbb\user($this->language, '\phpbb\datetime');
9696
$this->request = $this->getMockBuilder('\phpbb\request\request')
9797
->disableOriginalConstructor()

tests/functional/acp_manage_test.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public function test_acp_edit()
161161
$crawler = $this->get_manage_page();
162162

163163
// Hit edit button
164-
$edit_link = $crawler->filter('[title="' . $this->lang('EDIT') . '"]')->parents()->first()->link();
164+
$edit_link = $crawler->filter('[title="' . $this->lang('EDIT') . '"]')->ancestors()->first()->link();
165165
$crawler = static::click($edit_link);
166166
$this->assertContainsLang('ACP_ADS_EDIT', $crawler->filter('#main h1')->text());
167167

@@ -302,7 +302,7 @@ public function test_acp_delete()
302302
$crawler = $this->get_manage_page();
303303

304304
// Hit delete button
305-
$delete_link = $crawler->filter('[title="' . $this->lang('DELETE') . '"]')->parents()->first()->link();
305+
$delete_link = $crawler->filter('[title="' . $this->lang('DELETE') . '"]')->ancestors()->first()->link();
306306
$crawler = static::click($delete_link);
307307
$this->assertContainsLang('CONFIRM_OPERATION', $crawler->text());
308308

0 commit comments

Comments
 (0)