You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently in MigrationUtil class only the first 20 lines are read of the migration this can cause when cut unluckily into the following warning
PHP Warning: Unterminated comment starting line 1 in Command line code on line 1
Warning: Unterminated comment starting line 1 in Command line code on line 1
This warning is at current state suppressed using @. This sadly suppression can sadly not be detected by sentry (see following issue) and throws always a error there.
What is the case of just reading the first 20 lines, are there maybe today better ways? Should we just check if a comment was opened and close it manually before giving it to the function?
The text was updated successfully, but these errors were encountered:
It's the same in phpbench and I basically stole it from Stackoverflow.
It's faster than parsing an AST - we read the first 20 lines, and if there is no class then we try the next 20. Probably it could be smarter - maybe there's already a library which does this? classy is one example, maybe - this library does essentially the same thing but tokenizes the entire source file - I guess there might not even be much performance penalty.
Currently in MigrationUtil class only the first 20 lines are read of the migration this can cause when cut unluckily into the following warning
This warning is at current state suppressed using
@
. This sadly suppression can sadly not be detected by sentry (see following issue) and throws always a error there.What is the case of just reading the first 20 lines, are there maybe today better ways? Should we just check if a comment was opened and close it manually before giving it to the function?
The text was updated successfully, but these errors were encountered: