Imperfect QueryBuilderType detection returned by other method call

[janedbal]

See current behaviour:

class Foo {

    public function notWorking()
    {
        $queryBuilder = $this->createQueryBuilder();
        $queryBuilder->andWhere('1 = 1');

        $queryBuilder->getQuery()->getResult(); // mixed[]
    }

    public function working()
    {
        $queryBuilder = $this->createQueryBuilder()
              ->andWhere('1 = 1');

        $queryBuilder->getQuery()->getResult(); // list<Entity>
    }
}

This is because QueryBuilderMethodDynamicReturnTypeExtension detects only calls over QueryBuilder (second case) and optionally dives into the initial "other method" call to detect what happened there.

This could be fixed if I added some DynamicMethodReturnTypeExtension that is hooked to object and decided based on its return type (QueryBuilder) if OtherMethodQueryBuilderParser can be used to infer the enhanced QueryBuilderType. But no such thing is possible (hooking DynamicMethodReturnTypeExtension to any class).

Would you accept such PRs to accomplish this?

[janedbal]

Added object hooking support in phpstan/phpstan-src#2761

[janedbal]

POC in #500

[janedbal]

This is not issue anymore, it solved by #500

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.