Skip to content
This repository has been archived by the owner on Dec 6, 2019. It is now read-only.

Strtic Standards: PHP Version 5.4.7 #102

Open
Vansers opened this issue Apr 11, 2013 · 4 comments
Open

Strtic Standards: PHP Version 5.4.7 #102

Vansers opened this issue Apr 11, 2013 · 4 comments

Comments

@Vansers
Copy link
Contributor

Vansers commented Apr 11, 2013

So far, I have seen too much Strict Standards errors on phpVMS while using PHP Version 5.4.7. I'm thinking we should tackle this because what if the hosting upgrades their PHP Version. What you think?


Strict Standards: Accessing static property Operations::$get as non static in \phpvms\admin\modules\Operations\Operations.php on line 167

Strict Standards: Accessing static property Operations::$get as non static in \phpvms\admin\modules\Operations\Operations.php on line 168

@Oxymoron290
Copy link

I develop in a php5.4 environment also, and normally before submitting pull requests ill undo this fix to keep it uniform with the current installation. Check out commit a18d2d8 this is normally how I suppress the 5.4 strict standards, but I'm not sure if it's desirable.

Note: This commit undoes the suppression, which I accidentally added in commit b8f8681

@Vansers
Copy link
Contributor Author

Vansers commented Apr 11, 2013

No worries, I do as well develop on 5.4 as well. Just the feeling to be kept updated with PHP. ;)

We might should take a look this, keep the suppress in with the older build, but not sure if it will affect the other versions of PHP.

@nabeelio
Copy link
Member

Is there an update for that charts library?

@Oxymoron290
Copy link

I'm not sure, I haven't looked into it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants