Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Introduce a new directive ngx_ja3 [on|off] #56

Open
dedok opened this issue Feb 2, 2025 · 4 comments
Open

[Proposal] Introduce a new directive ngx_ja3 [on|off] #56

dedok opened this issue Feb 2, 2025 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@dedok
Copy link
Collaborator

dedok commented Feb 2, 2025

Description

We are planing to use this module in the production soon. But we also need a Nginx's configuration handler to off and off it for different server blocks and location block.

Proposal

Introduce a directive ngx_ja3 [on|off] for http, server, location contexts, and it should allow to off or on calculation of ja3. The default value is on.

@phuslu
Copy link
Owner

phuslu commented Feb 2, 2025

Strongly agree, it's useful when we try to add ngx_ja4 support.

@dedok I try to add you as collaborator, please see https://github.com/phuslu/nginx-ssl-fingerprint/invitations and accept if your are happy.

@dedok dedok self-assigned this Feb 2, 2025
@dedok
Copy link
Collaborator Author

dedok commented Feb 2, 2025

Accepted. I will introduce this directive and will send PR for the review. But it will be happened at the end of next week. Have some other tickets to go.

@dedok dedok added the enhancement New feature or request label Feb 3, 2025
@dedok
Copy link
Collaborator Author

dedok commented Feb 3, 2025

This will be done probably this week, since it's really important for multi tenant configurations. Also readme.md should be updated as well.

@dedok
Copy link
Collaborator Author

dedok commented Feb 6, 2025

Probably I will introduce it together with #61. It seems we have a few possibility to off this feature; the first one: introduce a directive, but problems is that location conf context and seems server context are not available in ssl sockets (need to double check it). The second approach is: introduce an options for listener, e.i. listen 443 ssl ja3_off; need research a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants