Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Introduce functional tests for the module #58

Open
dedok opened this issue Feb 2, 2025 · 4 comments
Open

[Proposal] Introduce functional tests for the module #58

dedok opened this issue Feb 2, 2025 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@dedok
Copy link
Collaborator

dedok commented Feb 2, 2025

Description

Many companies have CI/CD process which runs testing for the build of nginx. It prevents to have unsupported modules (for example: one module can break another module, or updating of 3rd party: for example openssl version)

Proposal

Introduce functional test using python 3 test framework that can be reused in CI/CD process to test that module works as expected.

@phuslu
Copy link
Owner

phuslu commented Feb 2, 2025

Emmm, I must admit that I was lazy at the beginning time then missed it, but I still don't have a good idea until now.

Because I found that nginx functional testing seems to rely heavily on perl, which I am not familiar with. It would be very helpful if it can be implemented using the python3 test framework.

@dedok
Copy link
Collaborator Author

dedok commented Feb 2, 2025

Well, I don't like nginx perl framework also, for example I use it, but very very limited. I can propose some of possible solution based on python tests framework that some of developers are using even for testing nginx. Give me about 1 or 2 weeks to collect references and prepare PoC for this module.

@dedok dedok added the enhancement New feature or request label Feb 3, 2025
@dedok dedok self-assigned this Feb 6, 2025
@dedok
Copy link
Collaborator Author

dedok commented Feb 6, 2025

First step: create a branch, introduce a PoC and introduce it to @phuslu .
What we need at least to test:
(1) Compatibility with nginx configuration (variables, map {}, maybe ?njs capture?).
(2) General logic of the work of the module.
(3) This should be complicated to run and should be compatible with GH CI/CD.

@phuslu
Copy link
Owner

phuslu commented Feb 6, 2025

Thanks, please go ahead at your own pace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants