Updated Clade Ontology to include and support Wojciechowski, 2003 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav
force-pushed
the
wojciechowski2003
branch
from
d3e85d1 to
5fda19c
Compare
…y into wojciechowski2003
… down the test suite.
hlapp
approved these changes
Jun 19, 2018
…in the PHYX file.
|
You're right, there isn't anything to review here apart from the JSON file itself. I'll merge it in now, but I'll keep working on making it easier to test this code in #36. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest update of the Curation Tool (phyloref/klados#66) adds a system for tracking the state of phyloreferences (phyloref/klados#25). This pull request takes one of those files and modifies the Clade Ontology to use the status information to determine which phyloreferences should be tested and which should be treated as TODOs.
I have managed to test this by using jphyloref's
--no-reasonermode, but it takes too long to run to include in the test suite proper (see a Travis test that timed out). The reasoned file that needs to be processed is 41MB, which would be very unwieldy to upload to Github. Therefore, I've decided that we should keep PHYX files that cannot be run in a reasonable amount of time in a separate directory (testcases_too_slow), and I've filed an issue to make testing of long-running PHYX files easier (#36).