Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional example files #232

Closed
1 task
gaurav opened this issue Jan 25, 2022 · 4 comments · Fixed by #278
Closed
1 task

Add additional example files #232

gaurav opened this issue Jan 25, 2022 · 4 comments · Fixed by #278

Comments

@gaurav
Copy link
Member

gaurav commented Jan 25, 2022

In PR #230, I removed the following example files:

This leaves us with a single small example file, Brochu 2003. This issue tracks us adding additional example files (probably from the Clade Ontology) to Klados. Ideally, they should demonstrate specimen identifiers (like Fisher et al did) or apomorphy-based phyloreferences. Using files from the Clade Ontology will almost certainly be easier than attempting to convert these v0.2.0 files to v1.0.0 Phyloref files.

  • Also check whether phyloreferences with specimens and external references as specifiers can be exported correctly as CSV.

Could be part of the tutorial (#227).

@gaurav gaurav added this to the Klados v1.0 milestone Jan 25, 2022
gaurav added a commit that referenced this issue Jan 25, 2022
These are v0.2.0 coded files rather than v1.0.0 coded files.
See #232 for details.
gaurav added a commit that referenced this issue Feb 15, 2022
This PR upgrades @phyloref/phyx.js to the latest version, allowing us to use reference-based (model 2.0) expectations (#65) and to export the ontology in n-Quads (#222). A few phyx.js methods have been renamed or replaced since this code was written; this PR updates them so that phyloref resolution works again.

See #231 and #232 for some follow-up changes that will be needed after this PR.

Closes #65, closes #204, closes #222.
@gaurav
Copy link
Member Author

gaurav commented Apr 8, 2022

Instead of recreating the old Brochu 2003 (which contained 17 clade definitions and 5 alternate definitions), we could include the 25 clade definitions from Sangster et al, 2022, which are open access (under the CC-BY-NC-ND license). Unlike Brochu 2003, however, they don't include their own phylogeny down to the species level showing where they expect these clades to resolve, so we would need to include them separately from Prum et al. (2015) and Kuhl et al. (2021).

@hlapp
Copy link
Member

hlapp commented Apr 8, 2022

Who would curate those definitions? And also, would it be wise to have different example datasets for different software products (if there aren't good reasons as to why one dataset would be much more suitable for one product than another)?

@gaurav
Copy link
Member Author

gaurav commented Oct 4, 2022

Who would curate those definitions?

We could use already-curated definitions from the Clade Ontology, as long as we find examples that really exercise Klados. By exercising Klados, I mean:

  • Having a variety of publication sources
  • Having a variety of phylogenies
  • Having a variety of specifier types: concept IRIs, apomorphies, specimens and taxa in a number of nomenclatural codes.

I think the phylorefs we've curated into JSON for the Clade Ontology has examples of all of these except for a variety of publication sources.

And also, would it be wise to have different example datasets for different software products (if there aren't good reasons as to why one dataset would be much more suitable for one product than another)?

I think there are different needs here: for phyloref.js, we needed something that used a number of Phyx.js features and tested that our Javascript library could process it properly. For the Klados examples, I think we want a number of examples that can show off different functionality in the app -- something we might want to use when demonstrating it to potential users, say. But it would make a lot of sense to move any example Phyx files we generate for this issue into phyloref.js so we can keep checking it during unit tests in that repository.

While working on the tutorial, I found an additional publication that might work as an example:

  • Resolving phylogenetic and classical nomenclature: A revision of Seraphsidae Jung, 1974 (Gastropoda: Neostromboidae) -- not open source (Zootaxa)
    • Defines both Terebellum P. F. Röding 1798 [S. J. Maxwell, T. L. Rymer & B. C. Congdon], converted clade name and Seraphs [S. J. Maxwell, T. L. Rymer & B. C. Congdon] 2021, new clade name as sister clades (I think?)

@gaurav
Copy link
Member Author

gaurav commented Oct 5, 2022

  • Need to put in a disclaimer that the apomorphy-based definitions cannot be resolved on a phylogeny
  • Use one of the apomorphy-based definition from Phylonym
  • Fisher should have a specimen-based definition, so we might be able to meet both needs with a single example

gaurav added a commit that referenced this issue Mar 8, 2023
This PR restores Fisher et al, 2007 from previous versions of Klados so that we can have examples of phyloreferences with specimens so we can make sure that Klados supports them. Closes #232.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants