-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional example files #232
Comments
These are v0.2.0 coded files rather than v1.0.0 coded files. See #232 for details.
This PR upgrades @phyloref/phyx.js to the latest version, allowing us to use reference-based (model 2.0) expectations (#65) and to export the ontology in n-Quads (#222). A few phyx.js methods have been renamed or replaced since this code was written; this PR updates them so that phyloref resolution works again. See #231 and #232 for some follow-up changes that will be needed after this PR. Closes #65, closes #204, closes #222.
Instead of recreating the old Brochu 2003 (which contained 17 clade definitions and 5 alternate definitions), we could include the 25 clade definitions from Sangster et al, 2022, which are open access (under the CC-BY-NC-ND license). Unlike Brochu 2003, however, they don't include their own phylogeny down to the species level showing where they expect these clades to resolve, so we would need to include them separately from Prum et al. (2015) and Kuhl et al. (2021). |
Who would curate those definitions? And also, would it be wise to have different example datasets for different software products (if there aren't good reasons as to why one dataset would be much more suitable for one product than another)? |
We could use already-curated definitions from the Clade Ontology, as long as we find examples that really exercise Klados. By exercising Klados, I mean:
I think the phylorefs we've curated into JSON for the Clade Ontology has examples of all of these except for a variety of publication sources.
I think there are different needs here: for phyloref.js, we needed something that used a number of Phyx.js features and tested that our Javascript library could process it properly. For the Klados examples, I think we want a number of examples that can show off different functionality in the app -- something we might want to use when demonstrating it to potential users, say. But it would make a lot of sense to move any example Phyx files we generate for this issue into phyloref.js so we can keep checking it during unit tests in that repository. While working on the tutorial, I found an additional publication that might work as an example:
|
|
This PR restores Fisher et al, 2007 from previous versions of Klados so that we can have examples of phyloreferences with specimens so we can make sure that Klados supports them. Closes #232.
In PR #230, I removed the following example files:
This leaves us with a single small example file, Brochu 2003. This issue tracks us adding additional example files (probably from the Clade Ontology) to Klados. Ideally, they should demonstrate specimen identifiers (like Fisher et al did) or apomorphy-based phyloreferences. Using files from the Clade Ontology will almost certainly be easier than attempting to convert these v0.2.0 files to v1.0.0 Phyloref files.
Could be part of the tutorial (#227).
The text was updated successfully, but these errors were encountered: