Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The constants in the enum should be named based on the coding conventions #174

Open
phillipstanleymarbell opened this issue Apr 19, 2020 · 0 comments
Open

The constants in the enum should be named based on the coding conventions #174

phillipstanleymarbell opened this issue Apr 19, 2020 · 0 comments
Assignees
@SamuelmsWong-zz
Labels
Bug

Comments

@phillipstanleymarbell
Copy link
Member

The constants in the enum should be named based on the coding conventions (e.g., kSunflowerInstructionLatencyIndexIF) to make their use left confusing, since the pipeline structure (P) also has fields called IF, ID, etc.)

https://github.com/physical-computation/sunflower-simulator/blob/e414503efde31eeec176b375a8522353f14d2165/sim/mextern.h#L46
phillipstanleymarbell added a commit that referenced this issue Oct 13, 2020
@phillipstanleymarbell
Merge pull request #179 from JamesTimothyMeech/patch-1
8be44cd 
Fix for issue #174 where sbench benchmarks fail to compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamuelmsWong-zz SamuelmsWong-zz

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phillipstanleymarbell @SamuelmsWong-zz