Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boostrap 4 + jQuery 3 #1464

Open
Marc-pi opened this issue Jan 17, 2017 · 7 comments
Open

Boostrap 4 + jQuery 3 #1464

Marc-pi opened this issue Jan 17, 2017 · 7 comments

Comments

@Marc-pi
Copy link
Member

Marc-pi commented Jan 17, 2017

from https://github.com/pi-engine/guide/issues/842 and
https://github.com/pi-engine/guide/issues/841

@Marc-pi Marc-pi added this to the Pi version 2.7 milestone Jan 17, 2017
@voltan
Copy link
Member

voltan commented Aug 30, 2018

For update to boostrap 4 and fontawesome to version 5:

  • update bootstrap files to version 4
  • update default theme front side
  • update default theme admin side
  • update setup
  • update system module templates
  • update user module template
  • update widget module template
  • update other core modules templates
  • check and update all core helpers and other codes
  • check and update localization for RTL languages
  • check and update date-piker if needed
  • check other js libs compat (inc. CKeditor)
  • Angular update

  • update news module
  • update order module
  • update shop module
  • update video module
  • update sitemap module
  • update notification module
  • update message module
  • update portfolio module
  • update guide module
  • update support module
  • update media module
  • update contact module
  • update statistics module
  • update event module
  • update subscription module
  • update comment module
  • update vote module
  • update tools module
  • update ads module
  • update favourite module
  • update search module
  • update ask module
  • update plans module
  • update blog module
  • update guestbook module
  • update reader module

@voltan
Copy link
Member

voltan commented Aug 30, 2018

I think update to jquery 3 finished

@Marc-pi
Copy link
Member Author

Marc-pi commented Aug 30, 2018

that's a huge work, i've added a task about other js libs
if we want to be good (performance wise), i think we have to work on pure BS4, not using their compat script

@voltan
Copy link
Member

voltan commented Aug 30, 2018

Understand , than I use not compacted version for all libes

@Marc-pi
Copy link
Member Author

Marc-pi commented Aug 30, 2018

https://getbootstrap.com/docs/4.1/migration/
i thought there were a code js snippet to run BS3 code on BS4 engine, maybe they remove.

btw, impact on Fontawesome also, maybe we have to update to FA5 too...

than I use not compacted version for all libes

of course please install minified version of all libs, but we need to check compatibility of our jquery plugins and other libs we use (Angular, CKEditor, etc.)

@voltan
Copy link
Member

voltan commented Aug 30, 2018

btw, impact on Fontawesome also, maybe we have to update to FA5 too...

Its my plan

of course please install minified version of all libs, but we need to check compatibility of our jquery plugins and other libs we use (Angular, CKEditor, etc.)

OK , sure

I will use this dco too https://getbootstrap.com/docs/4.1/migration/

@Marc-pi
Copy link
Member Author

Marc-pi commented Sep 3, 2018

@voltan
don't forget admin side !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants