Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress Coding Standards #62

Open
picandocodigo opened this issue Nov 21, 2013 · 5 comments
Open

WordPress Coding Standards #62

picandocodigo opened this issue Nov 21, 2013 · 5 comments

Comments

@picandocodigo
Copy link
Owner

Fix the code for the WordPress Coding Standards:
http://codex.wordpress.org/WordPress_Coding_Standards

@klemens-st
Copy link
Collaborator

I have this set up in the GUI repo, with automatic PHP Code Sniffer checks in Travis and Vagrant, using WPCS rules.

Most of the code can be automatically fixed with the phpcbf tool. If you are still interested I can implement it here as well. WPCS has indentation with tabs but it can be customized to 2 spaces as we use here.

@stale
Copy link

stale bot commented Jun 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jun 18, 2020
@klemens-st
Copy link
Collaborator

I have a branch with some stuff that deals with it.

@stale stale bot removed the wontfix label Jun 18, 2020
@picandocodigo
Copy link
Owner Author

@zymeth25 I've been trying to get rid of the if: endif; and foreach: endforeach; blocks, don't know why I used to think that's a good idea, you can't make PHP look like Ruby 😆. And also changing things I thought were ok at the time but I don't like now. I don't think we need to adhere 100% to the WordPress standards, some things I don't agree with, but we should at least have an internal standard that we adhere to for concistency. What do you think?

@klemens-st
Copy link
Collaborator

Yes I think that an internal standard is a good idea. We can just edit WPCS and adjust the rules we don't like. And then it can be automated with PHP Code Sniffer.

@stale stale bot added the wontfix label Aug 18, 2020
Repository owner deleted a comment from stale bot Aug 18, 2020
@stale stale bot removed the wontfix label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants